<html>
<head><meta charset="utf-8"><title>glacier review · t-release/triage · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/index.html">t-release/triage</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html">glacier review</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="218466024"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218466024" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218466024">(Dec 01 2020 at 18:59)</a>:</h4>
<p>What do I need to do as part of review before merging a glacier PR? For adding a new ICE, do I just make sure CI passes and glance at the code to make sure it's not malicious?</p>



<a name="218467016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218467016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218467016">(Dec 01 2020 at 19:06)</a>:</h4>
<p>I don't even know who's responsible for merging these :D<br>
Maybe <span class="user-mention" data-user-id="211727">@Jonas Schievink</span> can help</p>



<a name="218467056"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218467056" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218467056">(Dec 01 2020 at 19:07)</a>:</h4>
<p>Never worked on glacier, sorry</p>



<a name="218467197"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218467197" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218467197">(Dec 01 2020 at 19:08)</a>:</h4>
<p>Maybe <span class="user-mention" data-user-id="116122">@simulacrum</span> then?</p>



<a name="218467272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218467272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218467272">(Dec 01 2020 at 19:08)</a>:</h4>
<p>I have no context in terms of glacier, haven't touched it.</p>



<a name="218467316"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218467316" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218467316">(Dec 01 2020 at 19:09)</a>:</h4>
<p>It seems fine to do as you suggest though.</p>



<a name="218468805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218468805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218468805">(Dec 01 2020 at 19:22)</a>:</h4>
<p>Perhaps <span class="user-mention" data-user-id="239861">@Alex Macleod</span> knows: I think you've been active on glacier</p>



<a name="218473167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218473167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Macleod <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218473167">(Dec 01 2020 at 19:59)</a>:</h4>
<p>Yeah, apart from that double check the issue number in the filename is correct</p>



<a name="218578126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218578126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> John Simon <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218578126">(Dec 02 2020 at 16:07)</a>:</h4>
<p>sorry, do we have a triage meeting scheduled right now?</p>



<a name="218582435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/glacier%20review/near/218582435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/glacier.20review.html#218582435">(Dec 02 2020 at 16:33)</a>:</h4>
<p><span class="user-mention" data-user-id="260190">@John Simon</span> yes but unfortunately had some emergency work at that time and couldn''t connect to inform y'all</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>